Skip to content

Cedric/e2e test#133

Draft
Cedric / ViaDézo1er (viadezo1er) wants to merge 6 commits intomainfrom
cedric/e2e-test
Draft

Cedric/e2e test#133
Cedric / ViaDézo1er (viadezo1er) wants to merge 6 commits intomainfrom
cedric/e2e-test

Conversation

@viadezo1er
Copy link
Copy Markdown
Contributor

@viadezo1er Cedric / ViaDézo1er (viadezo1er) commented Apr 21, 2026

Tests only bt setup, (anonymous) telemetry should be added in the near future to allow us to focus on the most used commands.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Latest downloadable build artifacts for this PR commit bb4921fcb511:

Available artifact names
  • ``artifacts-build-global
  • ``artifacts-build-local-x86_64-apple-darwin
  • ``artifacts-build-local-x86_64-pc-windows-msvc
  • ``artifacts-build-local-aarch64-pc-windows-msvc
  • ``artifacts-build-local-x86_64-unknown-linux-musl
  • ``artifacts-build-local-x86_64-unknown-linux-gnu
  • ``artifacts-build-local-aarch64-apple-darwin
  • ``artifacts-build-local-aarch64-unknown-linux-gnu
  • ``artifacts-plan-dist-manifest
  • ``cargo-dist-cache

@viadezo1er
Copy link
Copy Markdown
Contributor Author

Cedric / ViaDézo1er (viadezo1er) commented Apr 30, 2026

Changing the setup to make language selection always happen:

diff --git a/src/setup/mod.rs b/src/setup/mod.rs
index c4a9df8..2e1e970 100644
--- a/src/setup/mod.rs
+++ b/src/setup/mod.rs
@@ -946,7 +946,7 @@ async fn run_default_setup(mut base: BaseArgs, args: SetupArgs) -> Result<()> {
         args.agents.agent,
         &detected,
         "Select coding agent",
-        ui::can_prompt(),
+        base.verbose,
     )?;

then running the test:

cargo test setup_supports_oauth_api_key_creation_and_explicit_claude_selection
...
failures:
    setup_supports_oauth_api_key_creation_and_explicit_claude_selection

fails as expected.

@viadezo1er
Copy link
Copy Markdown
Contributor Author

Wait I think something is wrong with the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants