Cedric/e2e test#133
Draft
Cedric / ViaDézo1er (viadezo1er) wants to merge 6 commits intomainfrom
Draft
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
d896518 to
c153d10
Compare
Contributor
Author
|
Changing the setup to make language selection always happen: diff --git a/src/setup/mod.rs b/src/setup/mod.rs
index c4a9df8..2e1e970 100644
--- a/src/setup/mod.rs
+++ b/src/setup/mod.rs
@@ -946,7 +946,7 @@ async fn run_default_setup(mut base: BaseArgs, args: SetupArgs) -> Result<()> {
args.agents.agent,
&detected,
"Select coding agent",
- ui::can_prompt(),
+ base.verbose,
)?;then running the test: fails as expected. |
Contributor
Author
|
Wait I think something is wrong with the tests |
3fdf4ca to
37c1039
Compare
2601894 to
bb4921f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests only
bt setup, (anonymous) telemetry should be added in the near future to allow us to focus on the most used commands.