Draft
Conversation
added 2 commits
February 11, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a readme in there for what to do but the short version is that it shifts import test to fixtures and gives you a script that will stub fixtures for you from a json file you have like this:
pnpm new-import-case --name simpsons-cancelation --from /tmp/span.jsonI could have done something more complicated but this felt as simple as possible while also getting rid of some of the annoying parts of setting these tests up.
I also pulled all the hardcoded tests out of
import.rsand moved them into fixtures.We can discuss if the fixtures are at the right scope, also. Maybe they should be an array of spans, maybe one span, I'm undecided.