Skip to content

Fix event-store Bandit baseline - #2

Merged
brainx merged 2 commits into
mainfrom
fix/bandit-event-baseline
Jul 31, 2026
Merged

Fix event-store Bandit baseline#2
brainx merged 2 commits into
mainfrom
fix/bandit-event-baseline

Conversation

@brainx

@brainx brainx commented Jul 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace dynamic event-list SQL assembly with fixed query variants while keeping cursor pagination, ordering, limit handling, and all four filters parameterized
  • preserve SQLite's primary-key seek for cursor pagination through a direct event_id > ? predicate
  • isolate subscriber exceptions at the post-commit callback boundary and emit only a fixed, data-free warning so later subscribers still run
  • add focused regressions for combined filtering and pagination, injection-shaped filter input, rowid query planning, persisted-event integrity, subscriber continuation, and secret-safe failure handling

Scope

This is a focused prerequisite for #1. It does not modify or replace that compatibility pull request and does not change Zeus compatibility, OpenAPI fixtures, Kimi support, versions, or documentation.

Verification

  • .venv/bin/python -m unittest tests.test_events — 6 tests passed
  • .venv/bin/bandit -r olymp — no issues identified; zero lines skipped and zero suppressions
  • sh scripts/repo_check.sh — passed; 197 tests, 85% coverage, formatting, Ruff, mypy, Bandit, lifecycle smoke, and repository scans
  • sh scripts/test.sh — 197 tests passed with 85% coverage
  • cursor query-plan regression — SEARCH events USING INTEGER PRIMARY KEY
  • git diff --check — passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b8f0037ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread olymp/events.py Outdated
@brainx
brainx merged commit c8c977e into main Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant