Skip to content

fix: runprocessfunction in RunProcessFunction.java #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: runprocessfunction in RunProcessFunction.java #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/net/bramp/ffmpeg/RunProcessFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package net.bramp.ffmpeg;

import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import java.io.File;
import java.io.IOException;
Expand All @@ -25,8 +24,8 @@ public Process run(List<String> args) throws IOException {
Preconditions.checkNotNull(args, "Arguments must not be null");
Preconditions.checkArgument(!args.isEmpty(), "No arguments specified");

if (LOG.isInfoEnabled()) {
LOG.info("{}", Joiner.on(" ").join(args));
for (String arg : args) {
Preconditions.checkArgument(!isUnsafeArg(arg), "Unsafe protocol specifier in argument");
}

ProcessBuilder builder = new ProcessBuilder(args);
Expand All @@ -37,6 +36,11 @@ public Process run(List<String> args) throws IOException {
return builder.start();
}

private static boolean isUnsafeArg(String arg) {
return arg.regionMatches(true, 0, "data://", 0, 7)
|| arg.regionMatches(true, 0, "gopher://", 0, 9);
}

/** Sets the working directory for the process using a path string. */
public RunProcessFunction setWorkingDirectory(String workingDirectory) {
this.workingDirectory = new File(workingDirectory);
Expand Down
Loading