fix: support table alignment cells with fewer than 3 dashes (Prettier compatibility) - #1
Open
mabyoungg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
is_alignment_cellexpects the remaining dashes to be at least 3 characters long (len(cell) >= 3).However, code formatters like Prettier automatically shrink table alignment cells to 1 or 2 dashes (e.g.,
| :-: |or| :--: |) if the column header and content are extremely short (1 or 2 characters). When this happens, the function incorrectly returnsFalse, causing the sorting bot to treat the alignment row as a regular data row and breaking the entire table layout.According to the GitHub Flavored Markdown (GFM) spec, an alignment cell is valid with 1 or more dashes.
Solution
>= 3to>= 1to ensure full compatibility with auto-formatters like Prettier under any header length.Thanks!