Add focused candle scrubbing - #266
Merged
Merged
Conversation
…scrub # Conflicts: # CHANGELOG.md # packages/react-native-livechart/src/components/LiveChart.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrub.dimTarget: "otherCandles"so the candle under the finger keeps its full up/down colors while every other candle body and wick dimsscrub.dimFadeMs(60 ms by default, 0 for instant) and keep the focused render on the UI thread by reusing the existing batched candle paths with a clipped full-strength passotherCandlesconfigWhy
Focused candle scrubbing gives the touched OHLC bar a clear visual priority without adding another positional marker. The configurable, short opacity transition keeps the interaction responsive while avoiding a hard visual snap.
Validation
npm run typecheck— passednpm run lint— passednpm test -- --runInBand --silent— 99/99 suites passed; 1,530 passed and 5 skippednpm run verify— typecheck and lint passed; its parallel Jest phase reproduced repository resource-saturation timeouts in 4 otherwise-passing suites, all of which passed in the serial full run aboveoptionsexport warning