Fix live dot shine-through while series is dimmed - #276
Open
brandtnewlabs wants to merge 2 commits into
Open
Conversation
brandtnewlabs
marked this pull request as ready for review
August 15, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seriesOpacitydims replacement data, then fade them back in once the series is fully opaqueLiveChartandLiveChartSerieswhile keeping strokes, fills, value lines, labels, axes, and badges on their existing opacity pathsRoot cause
The live-dot groups used
seriesOpacitydirectly. At partial opacity, Skia composited a translucent dot over its own line, so the stroke showed through the dot and the pulse remained visibly active. The indicator group now uses a discrete UI-thread target with a short fade: hidden for any dimmed series, visible again only at full opacity.Before and after
Both clips use the Line & area example and hold the chart at 50% opacity long enough to show the pulse behavior. In the updated example, the dimmed range remains frozen for the whole loading interval and a fresh current range replaces it on completion.
Verification
npm run verify— 103 suites passed, 1,576 tests passed, 5 skippednpx react-doctor@latest --verbose --diff— no issues in changed React files