Improve wording of intro and spec API of P3294#172
Open
bernhardmgruber wants to merge 1 commit intobrevzin:masterfrom
Open
Improve wording of intro and spec API of P3294#172bernhardmgruber wants to merge 1 commit intobrevzin:masterfrom
bernhardmgruber wants to merge 1 commit intobrevzin:masterfrom
Conversation
d215d5d to
d8dae46
Compare
c8f13e1 to
a515803
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! @andralex asked me to review is paper, but I only had time to read the Spec API section. Here are some wording improvements and feedback:
intnamedxis: ..."define_classcan only define an entire class, but not add to a started class that is already partially filled with declarations. If you want to make that point, please add a sentence .injectto be consteval function, so the returned value can be assigned to aconstexprvariable, which the lambda can access without capturing:which allows:
Which seems to provide a solution to the question. It's still cumbersome to pass in the scope to inject into. But if
std::meta::current()were consteval as well (which it should), we could just do:selfshould probably be a pointer so it corresponds tothis.