Feat/create delete tank functionality on ui#38
Draft
danvanhorn wants to merge 4 commits into
Draft
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://app-git-feat-create-delete-tank-functionality-on-ui.brewhops.now.sh |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #38 +/- ##
=======================================
Coverage 37.50% 37.50%
=======================================
Files 4 4
Lines 72 72
Branches 14 14
=======================================
Hits 27 27
Misses 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've added delete tank functionality to the ui (by way of the new
disabledfield in the db) and reduced the number of data requests made on the tank monitoring page to 1. This was a part of editing the tank monitoring fetch so that I could account for disabled tanks, we didn't want to delete them entirely because of batch/tank history reasons.closes #27
related to brewhops/api#19