Skip to content

Feat/create delete tank functionality on ui#38

Draft
danvanhorn wants to merge 4 commits into
devfrom
feat/create-delete-tank-functionality-on-ui
Draft

Feat/create delete tank functionality on ui#38
danvanhorn wants to merge 4 commits into
devfrom
feat/create-delete-tank-functionality-on-ui

Conversation

@danvanhorn

@danvanhorn danvanhorn commented Sep 22, 2019

Copy link
Copy Markdown
Collaborator

i've added delete tank functionality to the ui (by way of the new disabled field in the db) and reduced the number of data requests made on the tank monitoring page to 1. This was a part of editing the tank monitoring fetch so that I could account for disabled tanks, we didn't want to delete them entirely because of batch/tank history reasons.

closes #27
related to brewhops/api#19

@vercel

vercel Bot commented Sep 22, 2019

Copy link
Copy Markdown

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://app-git-feat-create-delete-tank-functionality-on-ui.brewhops.now.sh

@codecov

codecov Bot commented Sep 22, 2019

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.50%. Comparing base (f50c224) to head (626368b).
⚠️ Report is 11 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #38   +/-   ##
=======================================
  Coverage   37.50%   37.50%           
=======================================
  Files           4        4           
  Lines          72       72           
  Branches       14       14           
=======================================
  Hits           27       27           
  Misses         45       45           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants