Skip to content

fix(charts): add title back to charts object#42

Open
brennand97 wants to merge 2 commits into
devfrom
fix/chart-titles
Open

fix(charts): add title back to charts object#42
brennand97 wants to merge 2 commits into
devfrom
fix/chart-titles

Conversation

@brennand97

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercel Bot commented Sep 28, 2019

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/brewhops/app/evejcg2iy
🌍 Preview: https://app-git-fix-chart-titles.brewhops.now.sh

@codecov

codecov Bot commented Sep 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #42 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #42   +/-   ##
=====================================
  Coverage   37.5%   37.5%           
=====================================
  Files          4       4           
  Lines         72      72           
  Branches      14      14           
=====================================
  Hits          27      27           
  Misses        45      45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50c224...03eb7fd. Read the comment docs.

@danvanhorn danvanhorn self-assigned this Sep 29, 2019
@danvanhorn danvanhorn self-requested a review September 29, 2019 16:28

@danvanhorn danvanhorn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of minor comments but overall this is exactly what we needed.

Comment thread src/components/chart.vue Outdated
Comment thread src/components/chart.vue Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants