Add water ripple behind coin after flip lands#32
Open
brianruggieri wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recreates the classic expanding-ring water ripple (à la codepen.io/magnificode/pen/pbeJmV) behind the profile coin: ~700ms after a flip settles, three concentric rings spread out from under the coin across the blue sidebar and fade to nothing, clipped at the sidebar edge — as if the coin landed on water.
aria-hidden.coin-ripplecontainer with 3 spans inside#profileCoin(desktop-only wrapper, so mobile is untouched)themes/resume/static/css/resume.css): rings animatetransform: scale(1 → 4.75)+ opacity fade only (compositor-friendly, no layout/paint), 2.4s ease-out, 200ms stagger; first ring is a white "impact crest", the rest use the design-system--cyan. Rings paint atz-index: 3because the coin faces'::beforedrop shadow buries anything beneath them; starting atscale(1)hides the ring under the coin's dark rim so it still reads as emerging from behind. Desktop#sideNavgetsoverflow: hiddenso rings die at the blue edge and never touch the content column.coin-flip.js):fireRipple()fires 700ms after each flip (auto and click), restart-safe via reflow trick; skipped entirely under reduced motion (JS guard + CSSprefers-reduced-motionkill switch).resume.css?v=2,coin-flip.js?v=2.Test plan
npm test— all suites pass (canvas perf/reflow guard, achievements, experiments wall).is-ripplingapplied, rings animate (verified computed opacity/transform mid-flight), 0 console errors over a natural auto-flip cycleanimation: nonemedia query