Expose RSA_PKCS1_SHA1 for RSA signing#1503
Open
kjvalencik wants to merge 1 commit intobriansmith:mainfrom
Open
Expose RSA_PKCS1_SHA1 for RSA signing#1503kjvalencik wants to merge 1 commit intobriansmith:mainfrom
kjvalencik wants to merge 1 commit intobriansmith:mainfrom
Conversation
Owner
|
@kjvalencik Do you still need this? According to https://stackoverflow.com/a/60417115 Azure DevOps now does support better algorithms. |
Author
|
Yes, this is still needed. Even though Azure DevOps now supports |
|
Is this PR still active? We strongly need this feature when interaction with some old systems. |
kjvalencik
force-pushed
the
kv/rsa-sha1
branch
from
bc2d839 to
64436c5
Compare
Author
|
@nealwon I still need it and have been using a fork for it. Hopefully it can be eventually merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSA_PKCS1_SHA1_FOR_LEGACY_USE_ONLYis currently intentionally not available for RSA signing (only verification). However, it may be necessary when interacting with services that only support RSA SHA1 (e.g., Azure DevOps). This PR proposes exposing it publicly.There were no existing SHA1 test vectors because they were removed in 2015 are not present in FIPS 186-4. I updated
convert_nist_rsa_test_vectors.pyto be able to accept an algorithm filter and generated a new test vector file with the SHA1 test vectors from FIPS 186-2.This could be simplified by removing the test vector filtering code. The test runs fast enough that it would be fine to test everything from both versions.