Conversation
the aarch64 darwin _start was written in standard ARM syntax that mach's inline-asm dialect rejects, so darwin-aarch64 could not link: '#'-prefixed immediates (mach treats '#' as the comment char, stripped at lower time, so 'add x1, sp, #8' became 'add x1, sp,'), a 4-operand shifted-register add 'add x2, x1, x2, lsl #3', and a bitmask-immediate 'and sp, sp, #-16'. mirror the CI-tested linux aarch64 _start instruction-form style — bare immediates, an explicit lsl+add for the envp scale, and no explicit stack realignment (sp is 16-byte aligned on arm64 kernel entry) — while preserving the darwin semantics: entry symbol 'start', the _rt_argc/_rt_argv/_rt_envp capture, _rt_init then main, and the darwin 'svc 0x80' exit. closes #320
fix(runtime/darwin): rewrite aarch64 _start in mach's inline-asm dialect
release: v0.16.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration sweep of
dev→mainfor v0.16.1. No-fast-forward merge to preserve branching history.Contents
_startrewritten in mach's inline-asm dialect (bare immediates, explicitlsl+add, no#-immediates / shifted-register forms mach rejects) so aarch64-darwin links; darwin semantics preserved (runtime(darwin/aarch64): _start uses inline-asm forms mach's dialect rejects — blocks aarch64-darwin link #320, via fix(runtime/darwin): rewrite aarch64 _start in mach's inline-asm dialect #321).mach.toml0.16.0 → 0.16.1 + CHANGELOG (release: v0.16.1 #322).Notes
devinto a detachedmainresolved automatically with zero conflicts.mainis behinddevonly by the content-identical merge commits chore: repoint relocated repos to the briar-systems org #312 (hotfix) and release: sweep dev → main (v0.16.0) #319 (v0.16.0 sweep) — no merge-back needed.branch/main, so this reachingmainis what the darwin build (infra: CD-authored darwin release build (x86_64 + aarch64, native fixpoint) mach#1680) needs.v0.16.1is pushed separately after merge, not from this PR.