Conversation
|
Hey Aleksandar -- thanks for the contribution, and sorry for the delayed reply. This will take a bit time for me to review but I do want to thank you first for the efforts to make the project cleaner. |
| // For iOS, using UIKit | ||
| let userInterfaceStyle = UITraitCollection.current.userInterfaceStyle | ||
| return userInterfaceStyle == .dark ? .dark : .light | ||
| #elseif os(macOS) |
There was a problem hiding this comment.
just curious -- is this supposed to be the way to support both macOS and iOS?
| import Foundation | ||
| import OSLog | ||
|
|
||
| fileprivate let kPi = 3.1415926535897932384626433832795028841415926 |
There was a problem hiding this comment.
ouch. I wonder if any library provides this constant?
Double.pi?
| if !requestNew { | ||
| return uuid | ||
| } | ||
| if let stored = UserDefaults.standard.string(forKey: "BTID") { |
There was a problem hiding this comment.
some files are formatted with 4-space indentation while some others are with 2-space...
I remember using SwiftFormat and did not bother tweaking any its settings. Which formatter do you use and which preset ?
brills
left a comment
brills
left a comment
There was a problem hiding this comment.
That's all my comments. Thank you again.
There was a problem hiding this comment.
Should we update the Changelog / Release note about this?
| ) | ||
| Spacer() | ||
| Text("\(String(format: "%.0f", maxEl!)) deg") | ||
| Text("\(String(format: "%.0f", maxEl!)) °") |
| Spacer() | ||
| Text(userGrid) | ||
| } | ||
| HStack { |
There was a problem hiding this comment.
is there a better way to indicate this? The decision of presenting local time is only for my convenience and I'm not sure if it's a surprise to other users.
2 participants
Project refactoring for further improvements
Hello!
First, I want to express my gratitude for creating such an amazing project with SatHunter. Your work is truly inspiring, and I deeply appreciate the effort you’ve put into it.
As a first step towards better project organization and to pave the way for new contributions, I’ve made some changes to the project structure and refactored some variable names. I hope that these changes will make it easier for others to navigate the project and contribute in the future, as I will do.
I hope you find these updates helpful, and I look forward to seeing the project grow and evolve.
Thank you again for your hard work and dedication!
Best regards,
Alex, YT3TCA