Compatibility to "to_change" and "to_reorder"#336
Open
TonyZhou729 wants to merge 1 commit intobrinckmann:3.6from
Open
Compatibility to "to_change" and "to_reorder"#336TonyZhou729 wants to merge 1 commit intobrinckmann:3.6from
TonyZhou729 wants to merge 1 commit intobrinckmann:3.6from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I made small modifications to the to_reorder function in the analyze.Information class (analyze.py, lines 2248-2308).
Reason:
info.to_reorder used to fail for parameters renamed by info.to_change, as the to_reorder function checks the backup_names list, which does not include the renamed parameter. Passing in the original name does not work either, since it is the new name that must be passed into info.to_plot. This resulted in element not in list error when either the original or changed names was passed into info.to_change.
The modification fixes this, so now the new name defined in info.to_change can be passed into info.to_reorder for proper reordering. Testing confirms that this works for comparing multiple models as well. All modified parts in the code are enclosed in comments "Analyze modification" for you to view the details.
Thanks!
Tony