Open
Conversation
Owner
|
Hi Thomas, Thanks a lot for doing this, would you like to go ahead and add it to the private devel branch? I can also do it, but will be quite busy the next three weeks and might not get around to it soon. Then once we have everything there (e.g. DESI BAO and new WMAP Python 3 wrapper from @schoeneberg , NPIPE, ground based CMB, etc) we can put out a new release. If there are any other fixes or improvements you've done that haven't been included yet (e.g. PR #372 ) you can also add those. Thanks a lot! Best, |
Author
|
@brinckmann I actually forgot that I had access to the private repo. I can add the changes yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the BK18 likelihood based on the previous BK14 likelihood. I initially wanted to do it by inheriting from the BK14 likelihood class, but in the end a lot of small things had changed so I decided to copy-paste it and then edit it. There are actually two likelihoods, one using only B-modes (which is the default) called
BK18lf_dustand one that includes E-modes which is calledBK18lf_dust_incEE. The two likelihoods are identical and differ only in the datafiles and the maps used inside the .data file.To validate the likelihood I recreated Figure 4 of BKXIII in 2110.00483. Using this script:
I get these figures:

which at least by eye agree.