change async execution versions

[koudis]

Summary by CodeRabbit

• Releases

  • async-function-execution: dependency list simplified (nlohmann-json removed).
  • fleet-protocol-cpp: bumped to v1.2.0 and internal dependency ordering updated.

• Chores

  • CI/docker images updated to include Ubuntu 25.04.
  • Toolchain/CMake handling adjusted and a persistent CMake alias added for image/runtime consistency.

[coderabbitai]

Walkthrough

Manifest updates: removed nlohmann-json from async-function-execution manifests; reordered and updated dependencies and Docker image names in fleet-protocol-cpp (release bumped to v1.2.0); added ubuntu2504 to fleet-protocol-interface DockerMatrix; Dockerfile adjusted for cmake aliasing and script cleanup removal.

Changes

Cohort / File(s)	Summary
async-function-execution manifests package/async-function-execution/async-function-execution_debug.json, package/async-function-execution/async-function-execution_release.json	Removed nlohmann-json from DependsOn (leaving aeron). No other public/export changes observed.
fleet-protocol-cpp manifests package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json, package/fleet-protocol-cpp/fleet_protocol_cpp_release.json	Reordered DependsOn (moved fleet-protocol-interface position); replaced DockerMatrix.ImageNames entry fedora40 → ubuntu2504; release metadata bumped Git.Revision and Package.VersionTag v1.1.1 → v1.2.0.
fleet-protocol-interface manifests package/fleet-protocol-interface/fleet_protocol_debug.json, package/fleet-protocol-interface/fleet_protocol_release.json	Added ubuntu2504 to DockerMatrix.ImageNames.
Docker image/tooling docker/fleet-os-3/Dockerfile	Removed cleanup of downloaded cmake.sh and added persistent cmake alias entries into /root/.bashrc (alias insertion duplicated to ensure availability).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add support for Aeron 1.48.6 #12: Modifies the same async-function-execution manifest dependency entries (nlohmann-json changes).
• Update context #10: Updates DockerMatrix entries to add ubuntu2504 across package manifests.
• Use os-release instead of lsb_release #9: Changes Dockerfile/tooling for fleet OS images (related Dockerfile adjustments).

Suggested reviewers

• koudis
• MarioIvancik

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'change async execution versions' is too vague and generic. It uses non-descriptive phrasing that doesn't clearly convey what changes were made or their significance.	Make the title more specific by describing the actual changes, e.g., 'Remove nlohmann-json dependency from async-function-execution' or 'Update fleet-protocol-cpp version and dependencies' to better reflect the substantive changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch BAF-1183/aeron_add

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@docker/fleet-os-3/Dockerfile`:
- Around line 64-65: The RUN that appends an alias to /root/.bashrc will not
affect non-interactive build shells; replace the alias approach by either
creating a real symlink or wrapper for cmake at /usr/local/bin/cmake (so it
overrides the toolchain binary) or ensure /usr/local/bin is prepended to PATH
during build/runtime (e.g., export PATH with /usr/local/bin first) instead of
relying on the alias; update the Dockerfile step that currently runs echo "alias
cmake=..." so it implements one of these deterministic overrides for the cmake
binary.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json (1)

34-42: ⚠️ Potential issue | 🟠 Major

Ensure fedora40 → ubuntu2504 migration is applied consistently across all package manifests.

Verification reveals that while fleet-protocol-cpp was updated to remove fedora40 and add ubuntu2504, 44 of 50 package/app manifest files still reference fedora40, with only 16 files adopting ubuntu2504. This creates an inconsistent build matrix across the codebase. Either apply the platform support change uniformly to all manifest files or adjust the approach to ensure deliberate platform divergence is documented.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json` around lines 34 -
42, The ImageNames array shows a platform change (remove "fedora40", add
"ubuntu2504") but that change is not applied consistently across manifests;
update every package/app manifest that still lists "fedora40" so they instead
list "ubuntu2504" under the ImageNames key (or, if intentional divergence is
required, add a clear comment/README entry documenting why some manifests keep
"fedora40" and which manifests intentionally differ). Locate manifests by
searching for the ImageNames key and the "fedora40" string and replace or
document accordingly to ensure a uniform build matrix.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json`:
- Around line 34-42: The ImageNames array shows a platform change (remove
"fedora40", add "ubuntu2504") but that change is not applied consistently across
manifests; update every package/app manifest that still lists "fedora40" so they
instead list "ubuntu2504" under the ImageNames key (or, if intentional
divergence is required, add a clear comment/README entry documenting why some
manifests keep "fedora40" and which manifests intentionally differ). Locate
manifests by searching for the ImageNames key and the "fedora40" string and
replace or document accordingly to ensure a uniform build matrix.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6309e34 and 4ef8e06.

📒 Files selected for processing (7)

• docker/fleet-os-3/Dockerfile
• package/async-function-execution/async-function-execution_debug.json
• package/async-function-execution/async-function-execution_release.json
• package/fleet-protocol-cpp/fleet_protocol_cpp_debug.json
• package/fleet-protocol-cpp/fleet_protocol_cpp_release.json
• package/fleet-protocol-interface/fleet_protocol_debug.json
• package/fleet-protocol-interface/fleet_protocol_release.json

🚧 Files skipped from review as they are similar to previous changes (4)

• package/fleet-protocol-interface/fleet_protocol_release.json
• package/fleet-protocol-interface/fleet_protocol_debug.json
• package/async-function-execution/async-function-execution_debug.json
• docker/fleet-os-3/Dockerfile