refactor: rename internal signal modules#31
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a617131f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| module Signal = { | ||
| include Signals__Signal | ||
| } |
There was a problem hiding this comment.
Preserve benchmark-facing module file names
Switching the public wrappers to Signals__* modules means npm run build will no longer generate src/signals/Signal.res.mjs, Computed.res.mjs, and Effect.res.mjs. I checked .github/workflows/benchmark-pr-vs-main.yml and .github/workflows/benchmark-pr-vs-frameworks.yml: both run scripts/ci/benchmark-pr-vs-*.mjs, and those scripts’ resolveSignalsDir logic hard-codes the old filenames, so they will throw and fail the benchmark job after this change. Please either keep compatibility shim files with the old names or update the benchmark loaders in the same commit.
Useful? React with 👍 / 👎.
Summary
Validation