Skip to content

refactor: rename internal signal modules#31

Closed
brnrdog wants to merge 2 commits into
mainfrom
brnrdog/signals-rename-fix
Closed

refactor: rename internal signal modules#31
brnrdog wants to merge 2 commits into
mainfrom
brnrdog/signals-rename-fix

Conversation

@brnrdog

@brnrdog brnrdog commented Apr 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove from rescript-signals package.
  • Rename internal module files , , and to , , .
  • Keep the public entrypoint API in via module wrappers so existing API remains , , and .

Validation

  • npm run build
  • npm run test

@brnrdog brnrdog closed this Apr 22, 2026
@brnrdog brnrdog reopened this Apr 22, 2026
@brnrdog brnrdog closed this Apr 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a617131f5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1 to +3
module Signal = {
include Signals__Signal
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve benchmark-facing module file names

Switching the public wrappers to Signals__* modules means npm run build will no longer generate src/signals/Signal.res.mjs, Computed.res.mjs, and Effect.res.mjs. I checked .github/workflows/benchmark-pr-vs-main.yml and .github/workflows/benchmark-pr-vs-frameworks.yml: both run scripts/ci/benchmark-pr-vs-*.mjs, and those scripts’ resolveSignalsDir logic hard-codes the old filenames, so they will throw and fail the benchmark job after this change. Please either keep compatibility shim files with the old names or update the benchmark loaders in the same commit.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant