Feature: Frog attack pattern - #17
Conversation
… for the floorLevel constant. Fix for some of how the duck is drawn. (added new gifs) Now storing z-indices in playdateConstants. Frog projectile (spitball) has been set up but is not used
Fix z-indices
brody2002
left a comment
brody2002
left a comment
There was a problem hiding this comment.
Well Done sir 🎉
Couple changes to be made 🤙
There was a problem hiding this comment.
Why Did The same Duck Sprites get re-added? Are they resized?
| tongueExtra:setZIndex(101) | ||
| spitball:setZIndex(150) | ||
|
|
||
| frog.enterSFX = sound.fileplayer.new("Sounds/SoundEffects/CTMR") |
There was a problem hiding this comment.
Change Sound ? or keep it for now? 💀
| @@ -27,28 +29,58 @@ Frog.create = function() | |||
| frog.direction = left | |||
| frog.onGround = true | |||
| frog.velocity = { x = 0, y = 0} | |||
There was a problem hiding this comment.
Not being used anywhere in the code
frog.velocity
| duck.idleAnimation = AnimatedImage.new("Images/Duck/Gifs/Idle-1", {delay = 200, loop = true, first = 1, last = 2}) | ||
| duck.walkingAnimation = AnimatedImage.new("Images/Duck/Gifs/Walking-1", {delay = 200, loop = true, first = 1, last = 2}) |
There was a problem hiding this comment.
Since you made the Frog Scope more than just the frog. Can we just make this the ticket that also handles all the sprites? That way the changes to the duck are traceable to this ticket as well.
- Delete the unused .gifs
- Remake all the .gifs 96x96
- Remove the -1s on the file name
| local initialImage = duck.currentAnimation:getImage() | ||
| duck:setImage(initialImage) | ||
| duck:moveTo(200, playdateConstants.floorLevel - duck.height) | ||
| -- For some reason the image is scaled down to 2/3 size ?????????????????? |
There was a problem hiding this comment.
Make the comment
".gif scaled by 2/3"
that comment is ass
| local height = 240 | ||
| local width = 400 | ||
| local height_constant = 44 | ||
| local height_constant = 16 |
There was a problem hiding this comment.
height_constant doesn't really correctly portray what this value is used for. It should be something to do with the floor?
I also don't believe it's being used anywhere so maybe can delete it?
|
|
||
| frog.enterSFX = sound.fileplayer.new("Sounds/SoundEffects/CTMR") | ||
|
|
||
| -- Don't know WHY THE FUCK there need to be scalars on these but they are necessary AFAIK |
| local frog = graphics.sprite.new() | ||
| local tongueExtra = graphics.sprite.new() | ||
| local spitball = graphics.sprite.new() |
There was a problem hiding this comment.
I know it would be ass to redo your code to accomade a .png.
But since the duck is being resized, maybe resize your frog images so that there is less whitespace?
2 participants
The frog has an attack pattern and also some changes to the duck to fix his sprite a bit