Skip to content

[RFC] [BREAKING] mandatory default package identifier for Android#156

Draft
brody2consult wants to merge 2 commits intomasterfrom
mandatory-package-identifier-for-android
Draft

[RFC] [BREAKING] mandatory default package identifier for Android#156
brody2consult wants to merge 2 commits intomasterfrom
mandatory-package-identifier-for-android

Conversation

@brody2consult
Copy link
Copy Markdown
Owner

@brody2consult brody2consult commented Sep 22, 2019

with blank default package identifier

followup item for PR #153 - add native item with package ID to package.json

Note that this proposal is using back-ticks instead of single quotes. I think this is a little more proper for templating in general.

TODO items:

  • fix Android package identifier description text (PR fix Android package identifier description text #155)
  • test CLI with this update
  • update test suite using Stryker Mutator to help ensure no loss of test coverage
  • start using back ticks through the rest of the code (and tracking this update), maybe with some help from the eslint tool

with blank default package identifier
@brody2consult brody2consult self-assigned this Sep 22, 2019
@brody2consult brody2consult changed the title mandatory default package identifier for Android [RFC] [BREAKING] mandatory default package identifier for Android Nov 15, 2019
@brody2consult brody2consult changed the base branch from dev to master November 15, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant