fix(publish): add build verification gate and update go to 1.26.4#6
Merged
Merged
Conversation
This addresses the bug where workflows fail on macOS because the Darwin ARM64 binary appears missing from the OCI artifact. The artifact manifest for v0.5.1 is correct — the issue is that a silent cross-build failure could produce an incomplete artifact. Changes: - Add a "Verify multi-platform build" step to publish.yml that asserts all four platform binaries exist before invoking the publish action. - Add `artifact/` to .gitignore so local cross-build outputs are not accidentally committed. - Add `make cross-build` target for local reproduction of the CI build. - Update go directive from 1.26.3 to 1.26.4 to resolve GO-2026-5037 and GO-2026-5039 (osv-scanner clean now).
handcaught
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workflows fail on macOS with
open bin/darwin/arm64/criteria-adapter-shell: file does not exist. Investigation shows the v0.5.1 OCI artifact manifest is correct — the Darwin ARM64 layer is present. The failure mode is a silent cross-build regression that could produce an incomplete artifact.Changes
Verify multi-platform buildstep that fails fast if any platform binary is missing before publishing.artifact/to prevent local cross-build outputs from being committed.cross-buildtarget so developers can reproduce the CI packaging locally.1.26.3→1.26.4to resolve GO-2026-5037 and GO-2026-5039 (osv-scanner now clean).Verification
go build ./...,go vet ./...,go test ./...— all pass.make vuln-scan— 0 vulnerabilities (was 2 stdlib vulns at 1.26.3).make deps-outdated— no outdated direct dependencies.