chore: remove repo cruft + workstream-automation subsystem#256
Merged
Conversation
added 9 commits
June 6, 2026 22:02
Clears outdated/cruft files and the now-superseded workstream tooling. History retains everything if needed later. Removed: - workstreams/ (planning artifacts), PLAN.md - docs/contributing/, docs/perf/, docs/roadmap/, docs/security/ - examples/archived/, user_feedback/, architecture_archive/, architecture_notes.md, tech_evaluations/ - CONTRIBUTING.md, SECURITY.md, flakey-test-worklog.md, proposed_hcl.hcl - Workstream-automation subsystem: .criteria/workflows/ (bootstrap/develop/ pr_review), .github/agents/, tools/release/ (tag-claim tooling), and the Makefile self/self-loop/validate-self-workflows/workflow_% targets. - Orphaned workstream_review_loop test goldens. Reference cleanup in surviving files (README, AGENTS, docs, ADRs, issue/PR templates, sdk/CHANGELOG, CHANGELOG, .gitignore/.dockerignore, proto comment + regenerated bindings, and stale test comments) so no dangling links remain. Note: ./claude in the request matched only the untracked .claude/ local config (not in git), so it was left untouched.
…lizing - Lead with what Criteria is and the problem it solves (local FSM workflow engine, out-of-process adapters incl. AI agents/MCP, optional orchestrator). - Warning header notes the HCL language and adapter design are stabilizing, alongside the trusted-code/container guidance. - Make the quickstart accurate for the out-of-process adapter model: declare an adapter source and pin via 'criteria adapter lock'; use state.* outcome refs. - Refresh feature list (environments, control flow); drop the stale v0.2→v0.3 migration and phase-history sections.
- Lead with what Criteria is (agent-based workflows + extensible adapters) and the dual framing: an exploration of agentic dev/security/research workflows and an effort toward a production, AI-authorable workflow tool. - Add 'What it's trying to be' (goals: limited language → full directed graph with loop-safety; safe/reproducible-by-construction compiler; tech-agnostic reusable workflows; AI-friendly authoring; verifiable/debuggable graphs; aspirational durable pause/resume). - Add honest 'Project status': engine/compiler solid-ish; only copilot+shell adapters proven; adapter model recently reworked; TS/Python smoke-tested at best; environments lightly tested. - Remove competitor references (not competing with anyone). - Add 'Authoring workflows with AI' featuring 'criteria spec [--with-patterns]'; show 'compile --format dot' / 'plan' for debuggable graphs.
- Professional/technical tone; remove aspirational and sales language. - Component-status and language-feature tables with an explicit status legend (Working/Experimental/Untested/Partial/Not implemented). - Mark unimplemented/unsupported items: parallel map form, target=step.<name>, remote subworkflow sources (Not supported); adapter dev not wired into apply, pause/resume server-oriented (Partial); TS/Python + environments Untested. - Concise Model section (FSM with loop bounds, OCI-signed adapters, optional server); keep quickstart, AI authoring (criteria spec), adapters, orchestrator.
- Remove the 'target = step.<name>' (removed feature) row — no need to list removed items. - Move the server/orchestrator section to a short end note flagged as early and subject to significant change; Model just points to it.
- Add examples/tour: variables, for_each, parallel, wait, switch, and a top-level output in one workflow (replaces the scattered phase3-* demos). - Rename phase3-subworkflow → subworkflow (the one multi-file/subworkflow example). - Keep real examples: hello, build_and_test, copilot_planning_then_execution, plugins/greeter, llm-pack. - Remove demo_tour_local, while, file_function, fileset, templatefile, hash-encoding, perf_1000_logs, and the remaining phase3-* single-feature examples (and their goldens). - Update the validate target, examples/README, and docs/workflow.md references to the trimmed set; regenerate plan/compile goldens.
- workflow.md: plugins.md → adapters.md (renamed doc). - AGENTS.md: node_branch.go → node_switch.go (branch→switch rework). - adapters.md: point remote-deployment examples at docs/examples/ (the real location) instead of the non-existent examples/remote/. - Verified: zero broken relative links across docs/, README, AGENTS, examples.
Tighten the long-form docs to the README's terse, technical register and correct claims against the code. workflow.md: - Strip version/phase cruft (v0.x, Phase 4, W08/W14, "Future Shape" appendix, nested-format/W08 migration sections). - Fix the --var/--var-file contradiction (--var exists; on plan and apply only). - Replace the stale binary plugin-discovery section with the OCI lock/dev model; add adapter source/version attributes. - Rewrite the CLI section to the real command set; correct example paths. - Correct subworkflow output access (subworkflow.<key> in the step's own outcome projection; downstream via steps.<step>.*), source schemes (url:// not supported), and the requires attribute (parsed, not enforced). - Mark environments Untested; describe doc-example validation accurately. LANGUAGE-SPEC.md (prose only; generated regions untouched): - Fix parallel (list form, not `= true`), on_crash values (fail/respawn/abort_run), file() size cap (1 MiB default), variable types. adapters.md / adapter-remote-deployment.md: - Add status banners for lightly-tested surfaces; fix invalid HCL in examples (quoted next, `;` separators, labeled workflow block). dependency-policy.md / release-process.md: - Remove retired workstream IDs (WS*/D57); fix the dead internal/builtin independence check; clarify noop is a conformance fixture, not an in-tree adapter.
validate-docs.sh only scans LANGUAGE-SPEC.md and never reads the <!-- validator: ... --> comments, so they were dead weight in workflow.md and adapters.md. Drop them and the prose that described them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes outdated/cruft files and the now-superseded workstream-automation
subsystem from the repo. Everything remains in git history if needed later.
Removed
Cruft / outdated content
workstreams/(planning artifacts) andPLAN.mddocs/contributing/,docs/perf/,docs/roadmap/,docs/security/examples/archived/,user_feedback/,architecture_archive/,architecture_notes.md,tech_evaluations/CONTRIBUTING.md,SECURITY.md,flakey-test-worklog.md,proposed_hcl.hclWorkstream-automation subsystem (orphaned once
workstreams/is gone).criteria/workflows/— bootstrap → develop → pr_review self-dev workflows.github/agents/— workstream-* agents + tech-evaluatortools/release/— tag-claim toolingself,self-loop,validate-self-workflows,workflow_%targets(dropped from
.PHONYand theciaggregate)workstream_review_loopplan/compile test goldensReference cleanup
Fixed dangling references in surviving files so no broken links remain: README,
AGENTS, several
docs/pages + ADRs, issue/PR templates,sdk/CHANGELOG.md,CHANGELOG.md(de-linked dead doc pointers),.gitignore/.dockerignore,stale test comments, and the
events.protoversioning-policy comment (bindingsregenerated; proto-drift clean).
Validation
make build,go vet(all modules),make lint(imports + golangci-lint +baseline 24/24 + spec-check + no-todos),
make proto-check-drift,make validate,make validate-docs,make example-plugin, andmake test(root + sdk + workflow) all pass.
Notes
./claudein the request matched only the untracked local.claude/config (
settings.local.json, not in git), so it was left untouched.examples/archive→examples/archived/andarchitecture_notes→architecture_notes.mdinterpreted as the intended targets.Net: 234 files changed, +48 / −67,655.