Adds the option to only handle notFound or other server errors.#19
Open
trametheka wants to merge 1 commit intobrokenhandsio:mainfrom
Open
Adds the option to only handle notFound or other server errors.#19trametheka wants to merge 1 commit intobrokenhandsio:mainfrom
trametheka wants to merge 1 commit intobrokenhandsio:mainfrom
Conversation
Member
|
@trametheka apologies I missed this one! I like the idea of the PR though it might be a little out of scope for Leaf Middleware. However, if you'd like to update the PR to work with the existing release then I'll merge it! Unfortunately it may be a fair bit of work since LeafMiddleware has moved to async/await |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the middleware, works well. You may not be interested in this, thought I'd upstream it just in case you were (or even had a better solution). I basically needed leaf coverage for a whole app for .notFound, but only needed leaf coverage for certain routes for all other errors (app has both leaf and json/rest routes). Be nice if the NIO errors enum was an OptionSet.
Not a breaking change either.
Cheers.