Chore add dqr plugin#21
Conversation
hollandjg
left a comment
hollandjg
left a comment
There was a problem hiding this comment.
Couple of questions on the second file!
| build: | ||
| context: . | ||
| image: ghcr.io/brown-bnc/xnat:1.8.7.1 | ||
| image: xnat |
There was a problem hiding this comment.
Didn't check this the first time around: what does this change do? Is it necessary for adding the DQR plugin?
| volumes: | ||
| - "${PWD}/brownldap-provider.properties:/data/xnat/home/config/auth/brownldap-provider.properties" |
There was a problem hiding this comment.
Can you say something about this line? Why is it necessary to change ldap --> brownldap here?
hollandjg
dismissed
their stale review
Missed a file when reviewing the first time around.
| build: | ||
| context: . | ||
| image: ghcr.io/brown-bnc/xnat:1.8.7.1 | ||
| image: ghcr.io/brown-bnc/xnat:1.8.10.0-dqr |
There was a problem hiding this comment.
Just a question – this looks like the image which is going to be built from this version of the repo. Is that right? What's the deploy process?
There was a problem hiding this comment.
That's correct—the tag with which I plan to name the image. This hasn't been part of my process in the past, but I figured it would be helpful to update the docker-compose file to reflect the latest image. However, this won't affect the deployment process. Only helpful for someone using docker-compose to build XNAT locally. Our Kubernetes deployment pulls the image straight from the Github Registry, which is built on PRs and via the publish workflow action.
2 participants
No description provided.