fix(dv2): rename record_source example x5__* -> mp__* (B2) - #139
Merged
Conversation
The governance admission logic (audit_28_06_26 #12) proves it is source-agnostic by citing a third record_source convention alongside 1c__/pg_ops__. That example carried the name of the Kaggle seed dataset (X5 Retail Hero); under the legend (domain.md §5.3-5.4) it is the consolidated marketplace feed, mp__. Renamed in the 5 ClickHouse bv_customer_mdm__* view headers, the PostgreSQL port (03_business_vault.sql), the PostgreSQL governance live-verify seed literal (the one place x5__ was an actual value, not just prose), and both admission-test docstrings. Added a ratchet assertion to each admission test (checked on raw text, since the example lives in a header comment that the tests otherwise strip). domain.md §5.3/§5.4 updated to reflect the rename is done. x5__ was never a real record_source value in the generator/seeds (those emit 1c__/pg_ops__/wb__) -- it only existed as documentation vocabulary for this one audit story.
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1c__/pg_ops__. That example carried the name of the Kaggle seed dataset (X5 Retail Hero); under the legend (domain.md§5.3-5.4) it is the consolidated marketplace feed,mp__.bv_customer_mdm__*view header comments, the PostgreSQL port (03_business_vault.sql), the PostgreSQL governance live-verify seed literal (postgres/governance/verify_live.sh— the one placex5__was an actual value, not just prose), and both admission-test docstrings (test_dv2_business_vault_ddl.py/test_dv2_postgres_ddl.py).x5__absent /mp__present) to each admission test, checked on raw file text since the example lives in a header comment the tests otherwise strip for the parse-logic checks.docs/domain.md§5.3/§5.4 updated: the record_source prefix table drops the(currently x5__)note, and the planned-rename row is marked Done.x5__was never a realrecord_sourcevalue produced by the generator/seeds (those emit1c__/pg_ops__/wb__) — it only existed as documentation vocabulary for this one audit story, so this is a pure rename with no data/behavior change.Test plan
pytest tests/unit/test_dv2_business_vault_ddl.py tests/unit/test_dv2_postgres_ddl.py -q— 28 passedpytest tests/unit -q— 1589 passedruff check/ruff format --checkon all touched files — clean