chore(ci): put sdk/ under the ruff lint+format gate - #167
Merged
Conversation
The published PyPI package was gated weaker than src/: ci.yml ran ruff only over src/tests/scripts, so sdk/ accumulated format drift (async_client.py, cli.py, client.py). Add sdk/ to both ruff steps and apply the one-off `ruff format sdk/`. Makefile lint/format targets get scripts/ and sdk/ too, so `make lint` now matches CI exactly. Formatting-only for the SDK sources; no behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
DORA Metrics
MTTR note: No failed mainline CI runs in the selected window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Audit
audit_07_07_26.mdF1:ci.ymllintedsrc/ tests/ scripts/but notsdk/— the package we publish to PyPI was gated weaker than internal source. Three SDK files had accumulated format drift (async_client.py,cli.py,client.py).What
ci.yml:sdk/added toruff checkandruff format --check.ruff format sdk/— pure line-collapse to the repo's 100-char limit, no behaviour change.Makefilelint/format: aligned tosrc/ tests/ scripts/ sdk/somake lintreproduces CI.Verify
ruff check src/ tests/ scripts/ sdk/→ clean ·ruff format --check ...→ 371 files already formatted.Closes F1 of the 07.07 audit (plan
plan_07_07_26.md, S1).🤖 Generated with Claude Code