chore: ignore internal scratch + fix misleading exactly-once comment (P5.1/P5.2) - #210
Merged
Merged
Conversation
…xactly-once comment .gitignore (N-6/P5.2): add /.claude/, /*_local/, and the internal root-level notes/decks currently untracked-but-unignored (G2_AUDIT_REPORT.md, desc_for_julia*.md, new_plen_*, pii-deny-gate.md, s6-bridge-design.md, slice5-pg-control-plane.md, presentation*.html). Untracked-but-unignored is one `git add -A` from a public repo; no tracked file is shadowed. stream_processor (N-5/P5.1): the "Checkpointing for exactly-once" comment was misleading — checkpointing gives at-least-once source replay; the effective exactly-once at the serving layer is completed by the bridge's idempotent, event_id-keyed apply (bridge_consumer.py), which the comment now states. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two low-risk hygiene items from the audit plan (no behavior change).
.gitignore (N-6 / P5.2)
Add
/.claude/,/*_local/, and the internal root-level notes/decks that were untracked-but-unignored — onegit add -Afrom a public repo (G2_AUDIT_REPORT.md,desc_for_julia*.md,new_plen_*,pii-deny-gate.md,s6-bridge-design.md,slice5-pg-control-plane.md,presentation*.html). Verified no tracked file is shadowed andgit status --porcelainis now clean of untracked paths. Directly serves the "internal notes never ship" rule.stream_processor comment (N-5 / P5.1)
# Checkpointing for exactly-oncewas misleading. Flink checkpointing gives at-least-once source replay; theevents.validatedsink is built with noDeliveryGuarantee. The effective exactly-once seen at the serving layer is completed downstream by the bridge's idempotent,event_id-keyed apply (bridge_consumer.py, whose docstring says the same). Comment corrected to state the real guarantee.🤖 Generated with Claude Code