docs(auth): accepted-risk constraint note on per-process failed-auth throttle (S-7) - #215
Merged
Merged
Conversation
…(S-7) The failed-auth IP throttle is in-process while the request rate limiter is Redis-shared, so N replicas give an attacker N x the intended failed-auth budget. Accepted: API keys are 256-bit random values, brute force stays infeasible at any realistic replica count, and the throttle only needs to blunt log-flooding/scanning. Constraint comment documents when to revisit (key entropy drop, or alerting keying off this counter). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DORA Metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes audit finding S-7 as accept-with-rationale (the audit itself scored it low and offered acceptance given key entropy).
_failed_auth_windowsis per-process while the request rate limiter is Redis-shared — on N replicas the effective failed-auth budget is N× the configured value. Accepted because API keys are 256-bit random values (brute force infeasible at any realistic replica multiple) and the throttle's job is blunting log-flooding/scanning, not being the security boundary. The comment states the two conditions under which this must be revisited (moving the throttle to Redis alongsidecheck_rate_limit): key entropy drops, or failed-auth alerting starts keying off this counter.Comment-only change; auth mutation suite (92 tests) green locally.
🤖 Generated with Claude Code