Skip to content

ci(flink-smoke): bound the image build with a timeout and one retry #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brownjuly2003-code merged 2 commits into from
Jul 20, 2026
Merged

ci(flink-smoke): bound the image build with a timeout and one retry #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85874b6
ci(flink-smoke): bound the image build with a timeout and one retry
JuliaEdom Jul 20, 2026
09c0519
Merge branch 'main' into ci/flink-smoke-bounded-build
brownjuly2003-code Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/flink-smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,17 @@ jobs:
run: |
set -euo pipefail
marker="Job has been submitted with JobID"
# The PyFlink image build has stalled silently on registry/PyPI pulls
# before (30-min job timeouts on doc-only PRs #213/#218, zero build
# output after the ca-certificates layer) — bound the build and retry
# once so a transient network stall costs ~10 min, not the whole job.
if ! timeout 600 docker compose $COMPOSE_FILES build flink-job-runner; then
echo "flink image build stalled or failed — one retry"
timeout 600 docker compose $COMPOSE_FILES build flink-job-runner
fi
# Brings up the dependency graph (kafka, kafka-init, minio, minio-init,
# flink-jobmanager, flink-taskmanager) and builds the PyFlink image.
docker compose $COMPOSE_FILES up -d --build flink-job-runner
# flink-jobmanager, flink-taskmanager) with the image built above.
docker compose $COMPOSE_FILES up -d flink-job-runner

echo "Waiting up to 10 min for '$marker' in flink-job-runner logs..."
deadline=$((SECONDS + 600))
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/test_flink_smoke_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ def test_smoke_uses_the_flink_compose_overlay() -> None:
# PyFlink job image; without it the regression is not exercised.
assert job["env"]["COMPOSE_FILES"] == "-f docker-compose.yml -f docker-compose.flink.yml"
run = _submit_step(job)["run"]
assert "up -d --build flink-job-runner" in run
# The build is bounded + retried separately (silent registry stalls ate the
# whole 30-min job on #213/#218), and `up` must then run the locally built
# image rather than pulling upstream.
assert "timeout 600 docker compose $COMPOSE_FILES build flink-job-runner" in run
assert "up -d flink-job-runner" in run
assert "up -d --build" not in run


def test_smoke_criterion_is_job_submission() -> None:
Expand Down