add passwords + 2FA so the agent can log into sites#59
Conversation
There was a problem hiding this comment.
10 issues found across 17 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
There was a problem hiding this comment.
1 issue found across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
219f238 to
421aa52
Compare
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
9 issues found across 16 files (changes from recent commits).
Tip: instead of fixing issues one by one fix them all with cubic
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
8066844 to
bfac816
Compare
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
c3c308f to
988e19d
Compare
# Conflicts: # crates/browser-use-agent/src/tools/handlers/mod.rs # crates/browser-use-browser/src/browser_script_helpers.py # crates/browser-use-browser/src/lib.rs # crates/browser-use-tui/src/render.rs
domain-scoped secrets stored in the OS keychain (values never touch the model), TOTP/2FA, and allow/deny domain rules — modeled on browser-use's sensitive_data + allowed_domains.
Summary by cubic
Adds domain‑scoped passwords and 2FA with an encrypted store so the agent can log into sites securely, with per‑domain navigation rules and a TUI/CLI manager. Values stay encrypted and are redacted from outputs; adds an email config panel and clearer nav‑guard hints.
New Features
browser-use-secrets: AES‑256‑GCM encrypted store for passwords and TOTP seeds with RFC 6238/base32 validation.ScriptSecurity: injects secret metadata, resolves<secret>name</secret>at runtime gated by the current domain, and enforces allow/deny navigation with redirect catch; system prompt add‑on lists credential names by domain (names only)./secrets,/domains, and/emailpanels (masked input, search/scroll) plus/import-passwordsfor 1Password; CLIsecrets/domains; agent exposes read‑onlybrowser secrets|domains.Bug Fixes
Written for commit 402edba. Summary will update on new commits.