Document required browserify option "dedupe: false"#93
Open
kumavis wants to merge 5 commits intobrowserify:masterfrom
Open
Document required browserify option "dedupe: false"#93kumavis wants to merge 5 commits intobrowserify:masterfrom
kumavis wants to merge 5 commits intobrowserify:masterfrom
Conversation
Author
|
cc @goto-bus-stop @ljharb thanks/ |
Member
goto-bus-stop
left a comment
goto-bus-stop
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I like that you've given better var names to some things :) Would it be possible to revert the index.js whitespace changes?
| // Force browser-pack to wrap the common bundle | ||
| b._bpack.hasExports = true; | ||
|
|
||
| // for tests/debugging |
Member
There was a problem hiding this comment.
It's also for plugins to hook into factored pipelines. If you have a minification step for example it can be added to the factored pipeline by using this event.
| next(); | ||
| })); | ||
|
|
||
| // capture module's relative path. used for recovering entry point pathnames |
Member
There was a problem hiding this comment.
I would keep this comment but probably remove most of the others…tbh, I feel like many of the comments only restate the line and don't actually clarify much.
Author
There was a problem hiding this comment.
I added the comments to stay sane while trying to read through the code which i found unintuitive
Co-Authored-By: Renée Kooi <renee@kooi.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also:
{ dedupe: false }Fixes/Updates #51