Merged
Conversation
…se no external traffic.
…roxyMaster Adds the HarDummyTrafficAddon to the BrowserupProxyMaster, ensuring requests to dev-null.com are intercepted and handled internally without making external network requests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix typo
Revise CLAUDE.md
kiturutin
reviewed
Mar 27, 2025
| numeric_val = float(val) | ||
| else: | ||
| numeric_val = int(val) | ||
| val = numeric_val |
There was a problem hiding this comment.
Why only numeric values are allowed here?
| "description": "The dev-null.com domain is reserved for dummy traffic. Any requests to this domain will be intercepted and used to create HAR entries with custom values.", | ||
| "examples": [ | ||
| "http://dev-null.com/any/path", | ||
| "http://dev-null.com/any/path?timings.wait=150", |
There was a problem hiding this comment.
Maybe it's worth adding some prefix to all our request query params, just in case user wants to use that magic URL to track their own requests, which might also have some query parameters they want to track separately, but I'm not sure, maybe it's not our use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
You can also pass har values to set in the "traffic" you create via the query string
The HAR dummy traffic creator lets us generate per-request traffic and test how rapidly data can flow through our system.
We will make a test script pointing to this URL and see how fast we can call it, and how much data we can produce. We can drop it to low/no delay, or even make vu's loop with no delay during each iteration.