When constructing the path to the boot image, don't assume the NBI's are in a root level directory#4
Open
vmiller wants to merge 6 commits intobruienne:apifrom
Open
When constructing the path to the boot image, don't assume the NBI's are in a root level directory#4vmiller wants to merge 6 commits intobruienne:apifrom
vmiller wants to merge 6 commits intobruienne:apifrom
Conversation
|
I'm checking out this project, and came across your pull request. In trying to review this request, I noticed that your commit messages lack context, especially outside of this pull request. Somebody (like me) reading the commit logs later would have a bunch of trouble figuring out why you're doing something, the what being reasonably obvious from the code. There's some good tips about writing commit messages at https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch constructs the relative path to the boot image by subtracting the tftprootpath from the full path. Since tftprootpath is passed into bsdpy at runtime, it makes sense to use this instead of making any assumptions about directory depth.