pre-fill burst token bucket - #8
Open
mccraigmccraig wants to merge 1 commit into
Open
Conversation
this permits bursting to start immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this permits bursting to start immediately
i have an API with constraints -
50 calls per minute
2500 calls per day
i've modelled this with a throttle-fn for the per-minute constraint around a throttle-fn for the per-day constraint... problem is that even if i allow bursting on the per-day constraint i never get to use my 50 calls a minute without waiting for an age for the per-day constraint bucket to fill
this patch allows the per-day bucket to be pre-filled, so i can happily use my 50 calls per-minute until i've exhausted my per-day calls