Moved route matching into a separate method named parseToken.#18
Open
GertBurger wants to merge 1 commit intobrunotavares:masterfrom
Open
Moved route matching into a separate method named parseToken.#18GertBurger wants to merge 1 commit intobrunotavares:masterfrom
GertBurger wants to merge 1 commit intobrunotavares:masterfrom
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the parsing of routes out of the parse method so that one can parse/match token without dispatching them.
All the tests pass but I think the behaviour is changed slightly in that the first matching route is always returned whereas the previous version would continue looking at routes if the dispatch failed.
I have kept the return values for the parse method.