Bump GitHub Actions to v5 to fix Windows checkout flakiness#23
Open
bryanroscoe wants to merge 1 commit into
Open
Bump GitHub Actions to v5 to fix Windows checkout flakiness#23bryanroscoe wants to merge 1 commit into
bryanroscoe wants to merge 1 commit into
Conversation
The Tests run on PR #20's merge commit (46cf06c) failed on the windows-latest job — not in our Pester tests, but in `actions/checkout@v4` itself, with: fatal: could not read Username for 'https://github.com': terminal prompts disabled This is a known transient on the Windows runner image when checkout@v4 (Node.js 20) hits a particular auth state during `git fetch`. The same CI run produced a deprecation warning that Node 20 actions are being phased out (default flip to Node 24 in June 2026, full removal in September 2026). Bump both pinned actions to v5 (Node 24): - actions/checkout@v4 → v5 (both job blocks) - actions/upload-artifact@v4 → v5 Local Pester run is 121 passed / 4 skipped / 0 failed — the code is fine, the CI was wrong. This patch is workflow-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The Tests workflow on main went red after PR #20 merged. Looking at the failed run for commit `46cf06c`, the failure is not in our Pester tests — it's in `actions/checkout@v4` itself on the windows-latest runner:
```
fatal: Cannot prompt because user interactivity has been disabled.
fatal: could not read Username for 'https://github.com': terminal prompts disabled
```
That's a known transient on the Windows runner image when checkout@v4 (Node.js 20) hits a particular auth state during `git fetch`. The same CI run produced GitHub's deprecation warning that Node 20 actions are flipping to Node 24 by default in June 2026 and being removed in September 2026.
Fix
Bump both pinned actions in `.github/workflows/tests.yml` to v5 (Node 24):
Verification
Workflow-file-only change. No code, no test changes.