ps-pdb-03-lookup-assert: replace runtime assert! with debug_assert! and total_cmp#83
Merged
bryantharpe merged 1 commit intoJul 21, 2026
Conversation
…nd total_cmp Replaces the release-mode assert! on the recomputed largest edge in pattern-database lookup.rs with debug_assert!, so a corrupt or drifted catalog cannot panic release callers. Also replaces the partial_cmp .expect() with total_cmp, which is deterministic on NaN and never panics. Closes ps-pdb-03-lookup-assert.
bryantharpe
added
the
integrity:n-a
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the release-mode
assert!on the recomputed largest edge incrates/pattern-database/src/lookup.rswithdebug_assert!, so a corrupt or drifted catalog cannot panic release callers.Also replaces the
partial_cmp(...).expect("edge angle must be comparable")sort comparator withtotal_cmp, which is deterministic on NaN and never panics; NaN edges simply fail the ratio-band test and are skipped.Closes ps-pdb-03-lookup-assert.