Add macOS Intel build support#7
Conversation
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
|
@copilot |
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Updated to use |
|
@copilot why large, and not just macos-15-intel |
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds support for building separate macOS executables for Intel (x86_64) and Apple Silicon (ARM64) architectures, allowing Intel Mac users to download native builds instead of relying on Rosetta emulation.
Key Changes:
- Converted build matrix from simple list to explicit include-based configuration with architecture-specific artifact naming
- Split macOS build into two separate jobs: one for Intel and one for ARM
- Updated release workflow to upload both macOS architecture variants
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/build.yml |
Restructured build matrix to create separate Intel and ARM macOS builds with architecture-specific artifact names; updated release to include both variants |
README-BUILD.md |
Added note documenting dual-architecture macOS builds in GitHub Actions |
Critical Issue Found: The PR uses an invalid GitHub runner label macos-15-intel which does not exist. GitHub's macos-15 runners are Apple Silicon (ARM64), while Intel runners are macos-13 or macos-13-large. This will cause the workflow to fail.
| python-version: '3.13' | ||
| artifact-name: WoWSync-Linux | ||
| archive-name: WoWSync-Linux.tar.gz | ||
| - os: macos-15-intel |
There was a problem hiding this comment.
The runner label macos-15-intel is not a valid GitHub-hosted runner. According to GitHub's documentation, macos-15 runs on Apple Silicon (ARM64), not Intel. For Intel (x86_64) builds, you should use macos-13 or macos-13-large which run on Intel hardware. Consider changing this to macos-13 for Intel support.
| - os: macos-15-intel | |
| - os: macos-13 |
| - Or: `dist/WoWSync` (single executable) | ||
| - May need to sign the app for distribution | ||
| - Create DMG with: `hdiutil create -volname "WoW Sync" -srcfolder dist/WoWSync.app -ov -format UDZO WoWSync.dmg` | ||
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures |
There was a problem hiding this comment.
The documentation states "Intel (macOS 15)" but macOS 15 runners are Apple Silicon, not Intel. This should be corrected to reference the actual Intel runner being used (e.g., "Intel (macOS 13)").
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures | |
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 13) and Apple Silicon (ARM) architectures |
Adds separate build artifacts for macOS Intel (x86_64) and Apple Silicon (ARM64) architectures.
Changes
macos-15(Intel) alongsidemacos-latest(ARM), using explicit matrix configuration with architecture-specific artifact namesWoWSync-macOS.zip→WoWSync-macOS-ARM.zip, addedWoWSync-macOS-Intel.zipBuild Matrix
Users on Intel Macs can now download native builds instead of running ARM binaries under Rosetta.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.