Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Lines 50-50 refactored with the following changes:

• Replace call to format with f-string (use-fstring-for-formatting)

[sourcery-ai]

Function construct_page refactored with the following changes:

• Use f-string instead of string concatenation [×3] (use-fstring-for-concatenation)

[sourcery-ai]

Function copy_file refactored with the following changes:

• Replace interpolated string formatting with f-string [×2] (replace-interpolation-with-fstring)

This removes the following comments ( why? ):

# eg. src and dest are the same file
# eg. source or destination doesn't exist

[sourcery-ai]

Function is_valid_file refactored with the following changes:

• Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

[sourcery-ai]

Function day_has_passed refactored with the following changes:

• Move assignment closer to its usage within a block (move-assign-in-block)
• Simplify numeric comparison (simplify-numeric-comparison)
• Inline variable that is only used once (inline-variable)

[sourcery-ai]

Lines 24-28 refactored with the following changes:

• Ensure constant in comparison is on the right (flip-comparison)
• Replace call to format with f-string (use-fstring-for-formatting)
• Remove unnecessary calls to str() from formatted values in f-strings (remove-str-from-fstring)

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.21%.

Quality metrics	Before	After	Change
Complexity	3.59 ⭐	3.60 ⭐	0.01 👎
Method Length	43.33 ⭐	43.33 ⭐	0.00
Working memory	6.46 🙂	6.53 🙂	0.07 👎
Quality	78.37% ⭐	78.16% ⭐	-0.21% 👎

Other metrics	Before	After	Change
Lines	272	269	-3

Changed files	Quality Before	Quality After	Quality Change
constraint_processing.py	81.31% ⭐	80.43% ⭐	-0.88% 👎
dygraph.py	78.61% ⭐	78.36% ⭐	-0.25% 👎
perf_tools.py	72.16% 🙂	72.18% 🙂	0.02% 👍
simpleserver3.py	92.87% ⭐	92.94% ⭐	0.07% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
perf_tools.py	add_date	9 🙂	167 😞	10 😞	52.43% 🙂	Try splitting into smaller methods. Extract out complex expressions
constraint_processing.py	ConstraintObj.__init__	0 ⭐	77 🙂	11 😞	70.40% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!