Skip to content

Added 'override', ' before' and 'after' moose modifiers to symbols list. #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosfrodriguez wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Added 'override', ' before' and 'after' moose modifiers to symbols list. #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ function localVars(state: ParserState): boolean {
// line, or if this line starts with my or local
let match;
if (state.var_continues || (match = state.stmt.match(/^(?:my|our|local|state)\b/))) {
// The declaration continues unless there's a semicolon, signature end, or sub start.
// The declaration continues unless there's a semicolon, signature end, or sub start.
// This can get tripped up with comments, but it's not a huge deal. subroutines are more important
state.var_continues = !state.stmt.match(/[\)\=\}\{;]/);

let mod_stmt = state.stmt;
// Remove my or local from statement, if present
mod_stmt = mod_stmt.replace(/^(my|our|local|state)\s+/, "");
Expand Down Expand Up @@ -327,8 +327,8 @@ function fields(state: ParserState): boolean {
const attr = match[1];
MakeElem(attr, PerlSymbolKind.Field, "", state);
MakeElem(state.package_name + "::" + attr, PerlSymbolKind.PathedField, "", state);
} else if ((match = state.stmt.match(/^around\s+["']?(\w+)\b/))) {
// Moo/Moose overriding subs.
} else if ((match = state.stmt.match(/^(?:around|before|after|override)\s+["']?(\w+)\b/))) {
// Moo/Moose method modifiers (around/before/after/override).
MakeElem(match[1], PerlSymbolKind.LocalSub, "", state);
} else {
return false;
Expand Down