Skip stack trace continuation lines in compile diagnostic parser#184
Open
dwright wants to merge 1 commit intobscan:mainfrom
Open
Skip stack trace continuation lines in compile diagnostic parser#184dwright wants to merge 1 commit intobscan:mainfrom
dwright wants to merge 1 commit intobscan:mainfrom
Conversation
Perl's warning/error output includes indented stack trace lines (starting with a tab) when a warning or error has a call stack. Each of these lines matches the 'at <file> line <N>' regex and was being parsed as a separate Syntax: diagnostic, causing a single warning to generate 10-30 false errors in the Problems panel. Fix: skip any line beginning with a tab before attempting to parse it as a diagnostic. Stack trace lines always begin with a tab in Perl's output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perl's warning/error output includes indented stack trace lines (starting with a tab) when a warning or error has a call stack. Each of these lines matches the 'at line ' regex and was being parsed as a separate Syntax: diagnostic, causing a single warning to generate 10-30 false errors in the Problems panel.
Fix: skip any line beginning with a tab before attempting to parse it as a diagnostic. Stack trace lines always begin with a tab in Perl's output.