feat: Introduces IconThemeDataMix#766
Closed
tilucasoli wants to merge 3 commits intomainfrom
Closed
Conversation
Introduces IconThemeDataMix as a mix representation of IconThemeData and updates IconThemeModifierMix to use it for configuration and merging. Refactors related utility, config, and style mixin code to support the new structure. Updates tests to reflect the new API and property access patterns.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Collaborator
|
Closing — the widget modifier API was significantly refactored in #775 (Dart 3.10 update). This 5-month-old PR has likely diverged too far. If IconThemeDataMix is still desired, a fresh implementation against the current modifier architecture would be cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces
IconThemeDataMixas a mix representation ofIconThemeDataand updatesIconThemeModifierMixto use it for configuration and merging. Refactors related utility, config, and style mixin code to support the new structure. Updates tests to reflect the new API and property access patterns.Review Checklist
Additional Information (optional)
Is there any additional context or documentation that might be helpful for reviewers?