refactor: standardize spec test files#827
Closed
tilucasoli wants to merge 2 commits intomainfrom
Closed
Conversation
- Update controlling-widget-state.mdx tutorial to explain that hover/press work automatically but focus requires Pressable - Add docstrings to onFocused methods explaining the Pressable requirement - Update dynamic-styling.mdx and box.mdx with minor improvements - Update simple_box example
- Create flex_spec_test.dart following the box_spec_test.dart pattern - Fix group names in icon_spec_test.dart, image_spec_test.dart, stack_spec_test.dart - Add proper test names (replace empty strings with descriptive names) - Move spec tests to their respective directories: - stack_spec_test.dart -> stack/stack_spec_test.dart - zbox_spec_test.dart -> stack/stackbox_spec_test.dart - text_spec_test.dart -> text/text_spec_test.dart - Ensure consistent structure: Constructor, copyWith, lerp, equality, debugFillProperties, props, Real-world scenarios
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Standardization of test file structure across the codebase.
Description
This PR standardizes all spec test files to follow the pattern established in
box_spec_test.dart. It ensures consistency in naming, structure, and organization of spec tests.Changes
flex_spec_test.dartfollowing thebox_spec_test.dartpattern with full test coverageMutableStylerorStyleinstead ofSpec):icon_spec_test.dart:IconMutableStyler→IconSpecimage_spec_test.dart:ImageMutableStyler→ImageSpecstack_spec_test.dart:StackStyle→StackSpec'creates [Spec] with all properties''creates [Spec] with default values''interpolates between two [Spec]s correctly'stack_spec_test.dart→stack/stack_spec_test.dartzbox_spec_test.dart→stack/stackbox_spec_test.darttext_spec_test.dart→text/text_spec_test.dartReview Checklist
Additional Information (optional)
This is a refactoring PR that only affects test files. No production code changes.