Updated DeserializePush to use the URI parts Buckaroo uses to create a Push message#71
Open
robvangeloven wants to merge 1 commit intobuckaroo-it:masterfrom
Open
Updated DeserializePush to use the URI parts Buckaroo uses to create a Push message#71robvangeloven wants to merge 1 commit intobuckaroo-it:masterfrom
robvangeloven wants to merge 1 commit intobuckaroo-it:masterfrom
Conversation
…the hmac authorization header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the documentation isn't super clear in what the request URI should be when deserializing a message, this change updates the PushHandler so there's no more guessing from the users of the SDK what the correct format should be for the URI