Conversation
smaye81
commented
Jun 3, 2025
|
|
||
| @BeforeAll | ||
| private static void setUp() throws Exception { | ||
| public static void setUp() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
All of a sudden this warning was showing when running tests:
Gradle Test Executor 18 STANDARD_ERROR
Jun 03, 2025 3:44:38 PM org.junit.platform.launcher.core.DiscoveryIssueNotifier logIssues
WARNING: TestEngine with ID 'junit-jupiter' encountered a non-critical issue during test discovery:
(1) [WARNING] @BeforeAll method 'private static void build.buf.protovalidate.FormatTest.setUp() throws java.lang.Exception' should not be private. This will be disallowed in a future release.
Source: MethodSource [className = 'build.buf.protovalidate.FormatTest', methodName = 'setUp', methodParameterTypes = '']
at build.buf.protovalidate.FormatTest.setUp(SourceFile:0)
pkwarren
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates protovalidate-java to the new Protovalidate v0.12.0 release.
The v0.12.0 release added new conformance tests for validating rules on incorrect field types. As a result, this uncovered the same bug that was present in protovalidate-go (see bufbuild/protovalidate-go#247 for context).