Skip to content

Fix preview-card-footer editor links to use useIdeLink composable#279

Merged
Kreezag merged 3 commits into
masterfrom
copilot/fix-preview-card-footer-link
Apr 24, 2026
Merged

Fix preview-card-footer editor links to use useIdeLink composable#279
Kreezag merged 3 commits into
masterfrom
copilot/fix-preview-card-footer-link

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

The preview-card footer was building editor deep-links with its own hardcoded logic, diverging from the rest of the app and producing incorrect URLs for all IDEs except VSCode. It also silently ignored custom file path mappings.

Changes

  • preview-card-footer.vue: Replaced the bespoke editorLink computed with useIdeLink's buildLink(file, line), consistent with ray-frame, ray-file, sentry-exception-frame, and var-dump/preview-card

Before:

// Only handled vscode + a broken generic fallback; ignored path mappings
if (codeEditor.value == 'vscode') {
  return `vscode://file/${fileName}${line ? `:${line}` : ''}`
}
return `${codeEditor.value}://open?file=${fileName}${line ? `&line=${line}` : ''}`

After:

const { buildLink } = useIdeLink()

const editorLink = computed(() => {
  // ...
  return buildLink(fileName, line)  // pathToIDEFilePath + custom path mappings
})

All IDEs supported by pathToIDEFilePath (JetBrains, Sublime Text, Atom, TextMate, Nova, Zed, Cursor, VSCode) and user-configured file path mappings now work correctly in the footer.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix link to editor in preview card footers Fix preview-card-footer editor links to use useIdeLink composable Apr 21, 2026
Copilot AI requested a review from butschster April 21, 2026 06:53
@butschster butschster marked this pull request as ready for review April 21, 2026 06:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

📸 Storybook Screenshots

Screenshots for 1 changed component in this PR.

Shared/PreviewCardFooter

Default

Shared/PreviewCardFooter / Default


Auto-generated from Storybook stories of changed .vue files

@Kreezag Kreezag merged commit 9373e75 into master Apr 24, 2026
2 checks passed
@butschster butschster deleted the copilot/fix-preview-card-footer-link branch April 24, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Link to editor not using the pathToIDEFilePath in preview card footers

3 participants