fix: harden app store install defaults - #168
Draft
bugkeep wants to merge 1 commit into
Draft
Conversation
bugkeep
force-pushed
the
fix/app-store-install-defaults-review-v2
branch
2 times, most recently
from
July 25, 2026 23:57
7e8a560 to
5bb9ad5
Compare
bugkeep
force-pushed
the
fix/app-store-install-defaults-review-v2
branch
from
July 26, 2026 12:47
5bb9ad5 to
cb49b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Bitnami charts can still reference versioned images that moved from the active
bitnaminamespace to the frozenbitnamilegacynamespace. Tomcat also ships with its default webapps disabled, so a technically successful install can expose no usable default page.What changed
docker.io/bitnamilegacy/*references and enable the Bitnami legacy-image compatibility switchtomcatInstallDefaultWebappsonly when the chart declares that key and the user did not explicitly set itScope and compatibility
Registry reachability and domestic/overseas mirror routing are intentionally not implemented here; that work remains isolated in casosorg#112. This PR contains no workflow, configuration, or OCI mirror fallback changes and always emits canonical official image references.
Non-Bitnami charts are unchanged. Explicit private image registries and explicit Tomcat values remain authoritative. Existing API payloads and Helm operation persistence are unchanged.
Validation
go vet ./...go build ./...gofumptcleanFix: casosorg#101