Skip to content

fix: harden app store install defaults - #168

Draft
bugkeep wants to merge 1 commit into
masterfrom
fix/app-store-install-defaults-review-v2
Draft

fix: harden app store install defaults#168
bugkeep wants to merge 1 commit into
masterfrom
fix/app-store-install-defaults-review-v2

Conversation

@bugkeep

@bugkeep bugkeep commented Jul 25, 2026

Copy link
Copy Markdown
Owner

What this fixes

Bitnami charts can still reference versioned images that moved from the active bitnami namespace to the frozen bitnamilegacy namespace. Tomcat also ships with its default webapps disabled, so a technically successful install can expose no usable default page.

What changed

  • show the same install-compatible values in the App Store dialog that the backend will enforce
  • rewrite versioned Bitnami image values to canonical docker.io/bitnamilegacy/* references and enable the Bitnami legacy-image compatibility switch
  • derive changes from Helm's coalesced dependency values, then merge only changed paths into user values
  • enable tomcatInstallDefaultWebapps only when the chart declares that key and the user did not explicitly set it
  • apply the same preparation to synchronous installs, persisted streaming installs, and upgrades

Scope and compatibility

Registry reachability and domestic/overseas mirror routing are intentionally not implemented here; that work remains isolated in casosorg#112. This PR contains no workflow, configuration, or OCI mirror fallback changes and always emits canonical official image references.

Non-Bitnami charts are unchanged. Explicit private image registries and explicit Tomcat values remain authoritative. Existing API payloads and Helm operation persistence are unchanged.

Validation

  • repository's exact Go CI test and vet command
  • go vet ./...
  • go build ./...
  • gofumpt clean
  • temporary local behavior tests covered canonical legacy references, dependency aliases, minimal overrides, explicit private values, non-Bitnami charts, invalid values without mutation, and empty compatibility state
  • no Go test files are included in the commit

Fix: casosorg#101

@bugkeep
bugkeep force-pushed the fix/app-store-install-defaults-review-v2 branch 2 times, most recently from 7e8a560 to 5bb9ad5 Compare July 25, 2026 23:57
@bugkeep
bugkeep force-pushed the fix/app-store-install-defaults-review-v2 branch from 5bb9ad5 to cb49b79 Compare July 26, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] make these 5 apps work

1 participant