fix: retry Helm downloads and extend install timeout - #171
Draft
bugkeep wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App Store installs still fail unnecessarily when a Helm repository or OCI registry has a transient timeout, truncated response, HTTP 408/429, or HTTP 5xx response. The same index or chart can also be downloaded repeatedly while opening the install dialog and submitting the install.
The install path also had three related deadline and recovery problems: Helm used a fixed 10-minute readiness timeout, an active task could be treated as stale after 11 minutes even while a larger chart was still installing, and a failed install could leave a failed release and partial resources behind.
What changed
helmInstallTimeout, defaulting to 20 minutes, while preserving an explicit bound for the complete detached install operationWait,WaitForJobs, andAtomictogether so timeout and install failures clean up the failed release and resourcesScope and dependency
This fork PR is intentionally based on
fix/app-store-prerequisites-review, which combines the current #109 and #114 heads and resolves their existingstore/helm.goconflict. The PR itself contains one functional commit.The intended upstream order is #109, then #114, then this change.
Validation
go test ./...go vet ./...go build ./...deployed, exposed its endpoint, and uninstalled cleanly