Skip to content

exhumed v1.0 release (gofmt fix)#43

Open
bugsyhewitt wants to merge 2 commits into
mainfrom
rot/exhumed-lap-20260620T200500Z
Open

exhumed v1.0 release (gofmt fix)#43
bugsyhewitt wants to merge 2 commits into
mainfrom
rot/exhumed-lap-20260620T200500Z

Conversation

@bugsyhewitt

Copy link
Copy Markdown
Owner

Summary

this PR re-applies the v1.0 release after the prior PR's gofmt CI failure (see bugsyhewitt's 'Re-author when CI green' comment at PR #42 / 2026-06-20T19:08:32Z)

What changed since PR #42

  • Cherry-picked the v1.0 release commit 64289d1 from rot/exhumed-lap-20260619T173500Z (HEAD of the prior PR's branch) onto current main (still at 107545f, no upstream movement since). Clean cherry-pick with no merge conflicts.
  • Applied gofmt -w . to fix the Check formatting CI failure on internal/version/version_test.go (single-file, 3-line comment-continuation indent change — 2-space → tab-indent per gofmt rules).
  • No semantic content change in any file. All 4 v1.0 release files (version.go bump, CHANGELOG.md new, README.md edits, version_test.go new) come from 64289d1 unchanged except for the gofmt formatting.

Requirements satisfied

  • R-001: Cherry-picked 64289d1 from rot/exhumed-lap-20260619T173500Z onto new branch off origin/main (HEAD 107545f). Clean replay, no merge conflicts.
  • R-002: gofmt -w . followed by gofmt -l . returning empty (confirmed in ship-gate).
  • R-003: Formatting change committed as style(version): apply gofmt to version_test.go.
  • R-004: This PR title and body.
  • R-005: No merge by executor; Bugsy merges after review.
  • R-006: Ship-gate locally verifies gofmt -l . empty + full test suite 0 FAIL / 0 SKIP.

Ship-gate result (local)

go build ./...                                  → exit 0 (BUILD: PASS)
go test ./... -count=1                          → exit 0 (35 packages ok, 0 FAIL / 0 SKIP)
go vet ./...                                    → exit 0 (VET: PASS)
go mod tidy                                     → exit 0 (no-op, no go.mod/go.sum diff)
go test ./internal/version/... -count=1 -v      → TestVersion_IsV1_0_0 PASS, TestCHANGELOG_HasV1_0_0Entry PASS
gofmt -l .                                      → exit 0 (empty output — gofmt PASS)

Files changed (net from main)

File Change
internal/version/version.go 1 line modified: Version = "dev"Version = "1.0.0"
CHANGELOG.md New file (~46 lines): Keep-a-Changelog format, [1.0.0] — 2026-06-19 entry
internal/version/version_test.go New file (~32 lines): regression pin tests for Version and CHANGELOG
README.md 2 edits: §Status updated to v1.0.0 released, §Build example ldflags updated to Version=1.0.0

Path note

Repo lives at /home/xil/dev/necromancer/exhumed (NOT /home/xil/dev/necromancer/projects/exhumed). Wave-0 repos are top-level under ~/dev/necromancer/.

Do not merge — Bugsy merges after review.

bugsyhewitt and others added 2 commits June 20, 2026 16:21
…ntry

Per the necromancer suite objective ("drive every tool to v1.0"), this commit
flips exhumed from Version = "dev" (no version cut ever made) to 1.0.0 by:

  - Bumping internal/version/version.go Version constant from "dev" to "1.0.0".
  - Creating CHANGELOG.md with a top-level [1.0.0] — 2026-06-19 Keep-a-Changelog
    entry documenting the 7 completed roadmap items (file database, remote feed,
    detection engine, content extraction, recursive chaining, JSON output,
    single static binary release) plus a Changed entry for the version bump.
  - Updating README.md Status from "pre-v1.0" to "Released as v1.0.0.
    APIs are production-stable."
  - Updating README.md Build-from-source example release-build -ldflags from
    Version=0.1.0 to Version=1.0.0.
  - Adding internal/version/version_test.go as the Go analog of the Python
    wheel-ship-gate regression pin: two Test* functions verify Version == "1.0.0"
    and that CHANGELOG.md contains a "## [1.0.0]" entry, so the v1.0 contract
    cannot silently regress.

No new dependencies (go mod tidy is a no-op). No source-code changes outside
the 2 modified files + 2 new files above. The 14,297 LOC of non-test Go code
is untouched.

Verified: go test ./... -count=1 baseline 622 PASS / 0 FAIL / 0 SKIP; post-PR
624 PASS / 0 FAIL / 0 SKIP (622 + 2 new pin tests). go vet ./... clean.
go build ./... clean.

Refs: R-001..R-011 in exhumed-001-v1.0-release.md packet.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CI for PR #42 (exhumed v1.0 release, HEAD 64289d1) failed at the
"Check formatting" job with `gofmt -l .` flagging this file. The
diff is a 2-line comment-continuation indent change (2-space -> tab-
indent per gofmt rules); the semantic content (TestVersion_IsV1_0_0
and TestCHANGELOG_HasV1_0_0Entry test functions) is unchanged.

After this commit:
  - gofmt -l . exits 0 (clean)
  - go test ./internal/version/... PASSes both regression pin tests
  - Full ship-gate (build, vet, test, go mod tidy) still exits 0

This is the explicit "Re-author when CI green" follow-up per
bugsyhewitt's 2026-06-20T19:08:32Z comment on PR #42.

Refs: R-001..R-007 in exhumed-002-v1.0-release-gofmt-fix.md packet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant