fix: report teardown failures as failed tests #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorwhen accessing xdist options without pytest-xdist installedFixes #84
Changes
1. Report teardown failures
The condition in
pytest_runtest_logreportnow handles teardown failures the same way it handles setup failures - capturing them to override the test result.2. Fix xdist option access when xdist not installed
The
numprocessesoption only exists when pytest-xdist is installed. Previously,config.getoption("numprocesses")was called unconditionally, causing aValueErrorwhen xdist wasn't present.Rebase Details
This PR was rebased onto
mainwhich included PR #83 (tag-filters feature). A conflict occurred in__init__.pywhere both PRs attempted to fix the same xdist bug:--tag-filtersoption to filter tests usingexecution_tagmarker #83's approach: Added default parameter togetoption("numprocesses", None)getoption()We chose this PR's approach as it's more explicit and avoids calling
getoption()when the plugin isn't available.Test status: All 75 tests passing ✅
Test Plan
test_pytest_runtest_logreport_fail_exception_in_teardownthat verifies teardown failure overrides a passed call resultOriginal work by @jimsynz in #85